Skip to content

feat: added margin fee - #400

Open
anuj-ondc wants to merge 2 commits into
release-TRV14-2.0.0from
feat/marginChanges
Open

feat: added margin fee#400
anuj-ondc wants to merge 2 commits into
release-TRV14-2.0.0from
feat/marginChanges

Conversation

@anuj-ondc

Copy link
Copy Markdown
Collaborator

What does this PR do?

  • added margin fee

Type of change

  • feat — new feature
  • fix — bug fix
  • hotfix — urgent production fix
  • chore — maintenance, deps, config
  • docs — documentation only
  • refactor — no behaviour change
  • test — adding or fixing tests

How has this been tested?

Checklist

  • My PR title follows the format: type: short description
  • I have added/updated tests
  • No console logs or debug code left in
  • Linked issue below

Related issue

Closes #

quantity:
selected:
count: 1
margin:

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have this as

{ "selected": { "measure": { "value": "10", "unit": "PERCENT" } }, "minimum": { "measure": { "value": "8", "unit": "PERCENT" } }, "maximum": { "measure": { "value": "10", "unit": "PERCENT" } } }

@92shreyansh 92shreyansh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anuj-ondc Please update the margin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants